Allow for custom appCompatViewInflater #274 #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents or other custom UI library
msfjarvis
reviewed
Jul 1, 2022
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
I think you wanna remove the @Ignore here rather than the @Test
|
@jrodbx are you ok with the approach? should I put documentation somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and thus support for MaterialComponents or other custom UI library
It would be great to resolve the viewInfalter from the theme but we don't have a context before constructing Paparazzi. We could resolve it in the test function but it would add a lot of boilerplate. And we can't resolve it from within Parazzi as we need to obtain theme attribute as done in AppCompatDelegateImpl
we could maybe remove the
appCompatEnabledand have a sealed class for theappCompatViewInflaterClassNamebut I didn't want to change the Paparazzi API